Try to avoid flakiness on http helper timeout tests #11345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block the response only during a time or till the conext is done. Close body if a request object is returned.
jsoriano
added
review
Metricbeat
|
Not sure if the issue is addressed because I cannot reproduce it locally, I will run CI some times to see if it is fixed. |
ruflin
reviewed
Mar 20, 2019
| ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| <-c | ||
| select { | ||
| case <-time.After(5 * time.Nanosecond): |
There was a problem hiding this comment.
Timeout is set to 1 nanosecond, this is just a higher time.
|
jenkins, test this again |
2 similar comments
|
jenkins, test this again |
|
jenkins, test this again |
ruflin
approved these changes
Mar 21, 2019
|
jenkins, test this a fifth time please |
|
It went green for five runs in Jenkins and Travis, merging this. |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 21, 2019
Block the response only during a time or till the conext is done. Close body if a request object is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block the response only during a time or till the context is done.
Close body if a request object is returned.
Fix #11336